Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Size Selector Component #265

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Create a Size Selector Component #265

merged 8 commits into from
Aug 2, 2024

Conversation

JonasGz
Copy link
Contributor

@JonasGz JonasGz commented Jun 13, 2024 •
edited

Closes #23

Feature

Criação do componente de seleção de peso.

Visual evidences 🖼️

DESKTOP
desktop

MOBILE
mobile

Checklist
  • [ x ] Issue linked
  • [ x ] Build working correctly
  • Tests created
Additional info N/A

aalmeida00
aalmeida00 approved these changes Jun 14, 2024
View reviewed changes
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
Alecell
Alecell reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temos um problema de comportamento, precisamos que quando um size for selecionado ele seja animado para o centro e ai fique em destaque, da forma que está agora é um problema de usabilidade

Essa sessão aqui é um bom exemplo, porém precisamos que a troca de size tambem seja animada alem da troca de posição
https://www.medcel.com.br/serie
image

src/components/SizeSelector/index.js Show resolved Hide resolved
@JonasGz JonasGz force-pushed the issue-23 branch 2 times, most recently from b969706 to f013e61 Compare June 15, 2024 13:11
@Alecell Alecell mentioned this pull request Jun 19, 2024
Closed
3 tasks
@JonasGz JonasGz force-pushed the issue-23 branch 4 times, most recently from 955eb5b to 524dce6 Compare July 2, 2024 21:23
@JonasGz
Copy link
Contributor Author

JonasGz commented Jul 2, 2024

Temos um problema de comportamento, precisamos que quando um size for selecionado ele seja animado para o centro e ai fique em destaque, da forma que está agora é um problema de usabilidade

Essa sessão aqui é um bom exemplo, porém precisamos que a troca de size tambem seja animada alem da troca de posição https://www.medcel.com.br/serie image

refiz todo o componente e agora parece estar adequado para o que queremos.

Alecell
Alecell requested changes Jul 8, 2024
View reviewed changes
src/components/SizeSelector/index.scss Show resolved Hide resolved
src/components/SizeSelector/index.scss Outdated Show resolved Hide resolved
src/components/SizeSelector/index.scss Show resolved Hide resolved
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
DominMFD
DominMFD requested changes Jul 19, 2024
View reviewed changes
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
@JonasGz JonasGz requested a review from Alecell July 22, 2024 19:44
Alecell
Alecell requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

É O HOMEM, só um ajuste de css minimo

src/components/SizeSelector/index.scss Show resolved Hide resolved
@JonasGz
feat: create SizeSelector component
72536c5 
feat: add responsive

chore: changed imgs to template sting

fix: translation bug mobile

fix: add aria-checked event

feat: create new sizeSelector

feat: create methods and add navigation with keyboard

feat: finish component

fix: remove css noPet

fix: remove justify-content: center
@JonasGz
chore: reduce method handleKeyDown
3b1ed73
@JonasGz
chore: change name methods activeCard and remove width and height fix…
843e64d 
…ed for padding
@JonasGz
chore: remove next declaration
93130b3
@JonasGz
chore: change component for scroll-snap and scrollIntoView
4e11ec8
@JonasGz
feat: finish component 2.0
0ab0501
@JonasGz
chore: event for 'size:change'
77bf9d9
@JonasGz
chore: remove max width card and add min-width card-size
fcd19d9
Alecell
Alecell approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ow, tu é potente pra caralho vai toma no cu memo asfuytasfigfrbvtasudfyihgas

@Alecell Alecell merged commit b6bdf23 into devhatt:main Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alecell Alecell Alecell approved these changes

@aalmeida00 aalmeida00 aalmeida00 approved these changes

@DominMFD DominMFD DominMFD approved these changes

Assignees

@JonasGz JonasGz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Desenvolvimento de Componente Slider com Controle de Navegação
4 participants
@JonasGz @Alecell @aalmeida00 @DominMFD